-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sudo password required #164
Comments
Maybe we can check before the installation if the sentence "become: true" is present in the install.yml. It works on Ubuntu. I dev on Ubuntu 16.04. |
I think this is totally not a big deal to ask the sudo password every-time even if not necessary. BTW, root user exist on Ubuntu, the password is disabled by default by the account is still present. |
It is indeed not a big deal and not a big key features, it is just that i like giving my password only when needed because any bad code having root access can be dangerous (even not intentionally). The need of having sudo is important though for user on distro without sudo by default |
I'm not familiar with audible but for me it looks like a bad way passing the root password around and (by the way) writing it down in debug logs. Not sure what should happen, but on Ubuntu 16.04 the debug output is not changing whether I supply a valid password or not. Only if I leave it empty - it crashes. |
Todo list:
About the fact we ask the sudo password every time. As a playbook can contains multiple play, and in each play, the "become" command can be called in multiple level like in a task. We cannot know by advance if the sudo password will be required or not. |
Is there a reason that kalliope is not called with root priveleges? sudo kalliope install --git-url https:\\xyz or in a root shell. That would be the usual approach for apt and all the others? |
It's the usual approach for a package install. But we have based our module installation on Ansible and this one needs the sudo password inside its processing. Because the program is mostly used to deploy configuration on remote systems. |
Sudo is still required. But the password is now hidden. |
When installing a new neuron via the kalliope install CLI command, I have to enter my sudo password even though my neuron request no additional installation and resources directory is writable by current user.
Could it only ask password when needed ?
Also, what happens when sudo is not installed on the local system?
Seems to come from here:
https://github.com/kalliope-project/kalliope/blob/master/kalliope/core/ResourcesManager.py#L235
(Also, it seems it assume that the root user exists, so I'm wandering if this works on Ubuntu)
The text was updated successfully, but these errors were encountered: