Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine order of arguments in index, quo, issubgroup, isnormal, ... #17

Open
fingolfin opened this issue Mar 22, 2021 · 0 comments
Open

Comments

@fingolfin
Copy link
Collaborator

Several functions take two or more groups as arguments; typically a group and a (candidate) subgroup thereof. We should try to establish rules (as simple as possible) for this to ensure consistency and make it possible for users to understand code without having to always double check these orders.

In GAP, the rule is rather simple indeed: arguments are ordered by "size", where "size" is meant figuratively, not literally: First the "big" group, then the "subgroup" (resp. candidate for being a subgroup). So it is index(grp, sub), quo(grp, sub), issubgroup(grp, sub), isnormal(grp, sub), ...

However, in Julia, this is problematic: there, functions like issubset use the reverse order: issubset(subset, full) -- we discussed this further at oscar-system/Oscar.jl#163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant