Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable exception handling warnings in windows client code #38

Closed
GoogleCodeExporter opened this issue Apr 29, 2015 · 8 comments
Closed

Comments

@GoogleCodeExporter
Copy link

As per 
http://groups.google.com/group/airbag-discuss/browse_thread/thread/ddae205aea494
f73/c1736d1d382e6e7a#c1736d1d382e6e7a

This patch gets rid of those warnings.

Original issue reported on code.google.com by ted.mielczarek on 29 Sep 2006 at 6:02

Attachments:

@GoogleCodeExporter
Copy link
Author

Can we get away with putting these #pragmas into the .cc files?  If not, will 
this do
what we want in the headers?:

#pragma warning( push )
#pragma warning( disable : 4530 )
[...file contents...]
#pragma warning( pop )

I want to affect the warning state for other code as little as possible.

Original comment by mmento...@gmail.com on 29 Sep 2006 at 6:38

@GoogleCodeExporter
Copy link
Author

I think you can put them into the .cc files, yeah, or you can do the push/pop.  
You
just have to have that warning disabled while you include std::*.

Original comment by ted.mielczarek on 29 Sep 2006 at 7:29

@GoogleCodeExporter
Copy link
Author

Amended to push/pop in the headers, and I had to stick a disable in one cc file 
as
well.  This gets rid of all of those warnings in my build.

Original comment by ted.mielczarek on 30 Sep 2006 at 9:00

Attachments:

@GoogleCodeExporter
Copy link
Author

Original comment by mmento...@gmail.com on 18 Oct 2006 at 1:45

  • Added labels: Component-Client-Handler, OpSys-Windows

@GoogleCodeExporter
Copy link
Author

We've added a number of new files since this patch was initially created.  Ted, 
could
you provide a new patch?

Original comment by mmento...@gmail.com on 27 Oct 2006 at 4:14

@GoogleCodeExporter
Copy link
Author

Updated to tip.

Original comment by ted.mielczarek on 27 Oct 2006 at 6:42

Attachments:

@GoogleCodeExporter
Copy link
Author

Oops, plus that comment in crash_report_sender.cc.

Original comment by ted.mielczarek on 27 Oct 2006 at 6:45

Attachments:

@GoogleCodeExporter
Copy link
Author

Checked in, revision [56].

Original comment by mmento...@gmail.com on 27 Oct 2006 at 7:47

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant