Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for non-existent dump file in CrashReportSender::SendCrashReport #42

Closed
GoogleCodeExporter opened this issue Apr 29, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

Currently, passing a non-existent dump file to SendCrashReport will send a
request anyway, but it's malformed.  There's a check in GenerateRequestBody
for this, but the return value of GenerateRequestBody is ignored in
SendCrashReport.  The simple fix for this is to check the return value
there, and return false out of SendCrashReport if it fails.  This was
biting me because I was mangling my path on the way to the sender.  :-/

Original issue reported on code.google.com by ted.mielczarek on 3 Oct 2006 at 8:02

@GoogleCodeExporter
Copy link
Author

Original comment by mmento...@gmail.com on 18 Oct 2006 at 1:44

  • Added labels: Component-Client-Sender

@GoogleCodeExporter
Copy link
Author

Original comment by mmento...@gmail.com on 18 Oct 2006 at 1:50

  • Added labels: OpSys-Windows

@GoogleCodeExporter
Copy link
Author

Trivial patch.

Original comment by ted.mielczarek on 30 May 2007 at 12:19

  • Changed state: Accepted

Attachments:

@GoogleCodeExporter
Copy link
Author

Original comment by ted.mielczarek on 1 Jun 2007 at 11:47

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant