Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrashReportSender::SendCrashReport should provide response body to caller #44

Closed
GoogleCodeExporter opened this issue Apr 29, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

In crash_report_sender.h:
// TODO(bryner): we should expose the response to the caller.

It would be nice to get a response so the server could tell the client an
ID assigned to the crash report, for example, and then provide a web link
to look it up.


Original issue reported on code.google.com by ted.mielczarek on 4 Oct 2006 at 7:19

@GoogleCodeExporter
Copy link
Author

Original comment by mmento...@gmail.com on 18 Oct 2006 at 1:43

  • Added labels: Component-Client-Sender

@GoogleCodeExporter
Copy link
Author

In revision [41] (patch in #41), I made the sender check the http status code 
and
indicate success only when the code is 200.  We can still do more to address 
this
bug, but at least we won't think that we've succeeded when we really failed.

Original comment by mmento...@gmail.com on 19 Oct 2006 at 9:51

@GoogleCodeExporter
Copy link
Author

Here's a patch that adds a wstring parameter to SendCrashReport (and 
HTTPUpload) that
gets filled with the body of the server response if successful.  It can also be 
NULL
if you don't care about the response.  This also makes one slight change to the
response semantics: if the size of the response body isn't exactly the same size
specified in the Content-Length header, the operation returns false.

Original comment by incremen...@gmail.com on 8 Dec 2006 at 6:53

Attachments:

@GoogleCodeExporter
Copy link
Author

Fixed in revision 81.

Original comment by incremen...@gmail.com on 8 Dec 2006 at 8:49

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant