Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4 #229

Closed
wants to merge 1 commit into from
Closed

Swift 4 #229

wants to merge 1 commit into from

Conversation

pdupris
Copy link

@pdupris pdupris commented Oct 13, 2017

Description of the Changes

Updated to support Swift 4 and Xcode 9.

Did not update pod version - i'll leave this to the Kaltura team

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • [NA] new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • [NA] Docs have been updated

@kaltura-fe-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@kaltura-hooks
Copy link

Hi @pdupris,
Thank you for contributing this pull request!
Please sign the Kaltura CLA so we can review and merge your contribution.
Learn more at http://bit.ly/KalturaContrib

@ElizaSapir
Copy link

Hey @pdupris,

Thanks for your PR.

  • Please make sure Travis get a green light by fixing the following issue on your PR:
Check dependencies
“Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.
“Swift Language Version” (SWIFT_VERSION) is required to be configured correctly for targets which use Swift. Use the [Edit > Convert > To Current Swift Syntax…] menu to choose a Swift version or use the Build Settings editor to configure the build setting directly.
  • Don't forget to sign CLA, then we will approve your PR.

Thanks,

Eliza

@ElizaSapir
Copy link

@pdupris hey, please close this PR and open new one based in develop (not master).

Thanks!

@ElizaSapir
Copy link

ElizaSapir commented Oct 25, 2017

Hey @pdupris,

Thank you for contributing this pull request!

  • Since we have a lot of repos that are dependent with this repo (PlayKit-Core) we have to add additional fixes.
  • All PRs must be open in front of Develop.

We are going to close this PR and manage swift4 support on: #232 please follow and add attachments or any feedback you wish.

Thanks!!!

cc @vadimkononov, @OrenMe

@ElizaSapir ElizaSapir closed this Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants