New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seeking while session is connected to Airplay crashes the SDK and the app #280
Comments
Hi, I ran tests on our sample apps, but couldn't reproduced the crash. Thanks. |
Hi, I was able to reproduce the crash in the playkit app with the existing video urls. I created this pull request so you can have the exact same conditions where i recreated the crash kaltura/playkit-ios-samples#28 Note: You will need to slide back and forth several times, even if the video didn't finish buffering between slides Thanks |
I am the lead iOS developer from the Motor Trend team. We were also able to reproduce this crash when airplaying the Kaltura player from an iPhone 6S running iOS 11.4 to an Apple T.V. (4th generation) running tvOS 11.4.1. To reproduce, we simply airplay a VOD from the Kaltura player to the Apple T.V. and start seeking either forward or backward. The crash happens consistently every time, and we get the exact same exception reported above (cannot seek to time INVALID). Our team has yet to propose a solution to the crash, but I just wanted to add our voice to the issue. We will update you when we decide upon a course of action. |
I should also point out that we tested this issue on two separate versions of PlayKit. On the older version (3.1.x-dev), the crash happens the moment you start seeking during an Apple T.V. airplay session. On the newer version (3.5.0), it takes a little longer for the crash to happen. In our testing experience, you had to seek back and forth several times before the crash would trigger. So it's pretty clear that the library keeps getting better, but there's still an underlying issue here. |
Hi Anho and Theodore, First of all thank you. |
Thank you! We'll give it a try. |
Merged to develop. |
@x-NR-x do you know when the next release will be? |
Hi @kjoneandrei , The version including the fix has been released, v3.5.0. |
@x-NR-x thank you :), it just seems like I got this dates when checking this log here v3.5.0...develop |
Prerequisites
In order to trigger the crash it is needed to enable Airplay and play a video content with Airplay while seeking back and forth from the player
Expected behavior
Video should seek to the desired position selected (seeking more than 1 time is probably needed as this seems to happen at random)
Actual behavior
Player tries to seek to position but crashes
Console output
Output in console ->
Output in crash logs ->
Note that
***** set current time to2: 1228.6467246747
is printed before callingplayer.seek(to: player.duration * Double(slider.value))
additionally tried replacing the above call to
player.currentTime = player.duration * Double(slider.value)
but crash still occurredThe text was updated successfully, but these errors were encountered: