Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build PlayKit on iOS 13 with Xcode 11.3.1 #394

Closed
5 of 6 tasks
bensLine opened this issue Mar 6, 2020 · 3 comments
Closed
5 of 6 tasks

Cannot build PlayKit on iOS 13 with Xcode 11.3.1 #394

bensLine opened this issue Mar 6, 2020 · 3 comments

Comments

@bensLine
Copy link

bensLine commented Mar 6, 2020

I created a sample project with PlayKit as a dependency. When I try to run the xcworkspace after pod install I get compile errors in PlayKit.
I'm using the latest release 3.16.1 with Xcode 11.3.1 (11C504) for iOS 13.

Prerequisites
  • Have you checked for duplicate issues: yes
  • Which Player version are you using: 3.16.1
  • Can you reproduce the issue with our latest release version: yes
  • Can you reproduce the issue with the latest code from master: didn't check, master is behind release 3.16.1
  • What devices and OS versions are you using: iOS 13, tried to build it on a simulator
  • If applicable, add test code or test page to reproduce: see example project KalturaTest.zip
Expected behavior

I can use PlayKit as a dependency on an iOS 13 project with Xcode 11.3.1 and Swift 5.1.

Actual behavior

PlayKit does not compile as a dependency on an iOS 13 project with Xcode 11.3.1 and Swift 5.1.

image
...

@bensLine
Copy link
Author

bensLine commented Mar 6, 2020

turned out to be because of a misconfigured pod file. I copied the following from your documentation which is also stated in your Example Podfile

post_install do |installer| 
    installer.pods_project.targets.each do |target| 
        target.build_configurations.each do |config| 
            config.build_settings['ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES'] = 'NO'
 	    if target.name == 'PlayKit'
	           config.build_settings['SWIFT_VERSION'] = '4.0'
	    end
        end 
    end 
end

Without specifing to build PlayKit with config.build_settings['SWIFT_VERSION'] = '4.0' it works. 👍

You might want to go through your documentation and also the links in your Readme, there are several posts and it's not clear to me which one to use. e.g. the following two links provide starting guides with different pod files
https://developer.kaltura.com/player/ios/getting-started-ios
https://vpaas.kaltura.com/documentation/Mobile-Video-Player-SDKs/v3_iOS_QuickStart.html

@bensLine bensLine closed this as completed Mar 6, 2020
@x-NR-x
Copy link
Collaborator

x-NR-x commented Mar 9, 2020

Hi @bensLine,

Thank you for contacting us.
I'm glad to hear you succeeded.

This example is deprecated, it's only kept for the test that are in there.
All sample can be found here:
https://github.com/kaltura/playkit-ios-samples

And regarding the documentation, this is the most updated one (the fist you mentioned):
https://developer.kaltura.com/player/ios/getting-started-ios
Updating all documentation we have is a procedure we are going through daily.

Sorry for any inconvenience.

Thanks,
Nilit

@bensLine
Copy link
Author

bensLine commented Mar 9, 2020

Coll, thanks for the clarification Nilit.
Cheers,
Benni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants