New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposed uri in PKPlaybackInfo #401
Conversation
Hi @naveen-c, |
@naveen-c the URI is the playback URI you set for the asset, what is the use case for it? don;t you already have it? |
@OrenMe In the case of HLS video, the URI in AVPlayerItemAccessLogEvent represents the URI of the currently selected HLS stream (entries in .m3u8 file). |
Got it, thanks. |
We also expose this as a track change event so analytics can track this data:
|
Got it. |
@OrenMe shall I go ahead and make these changes in VideoTrackChanged event? |
Thanks @naveen-c , please let us check as the model needs to fit between various SDKs we expose and it is usually not common to identify a stream by its url also in ends that support this. |
Hi @naveen-c, Did you have the time to check what is done on your side for the Web and Android implementation for this case? Thanks, |
@OrenMe , @x-NR-x sorry for the delay in response. |
@naveen-c are you patching your copy of playkit-android to get this? or using the profiler interface? |
On Android we are using exoplayer directly, and not kaltura's sdk |
Thanks @naveen-c, as we need to have compatibility in data model across SDKs we first will need to standardise this across them. |
@OrenMe thanks for the update. For some reason, bitrate is not enough for our analytics. Also, until you make a decision on standardizing the data across SDKs and expose the requested data, is it fine if I use my fork of the repository in my project? |
Hi @naveen-c , so resolution data will solve your issue? Is that the important info for your case? |
@OrenMe I think resolution can help, I will check with the team on this. So the FK project has multiple sub-projects in itself, and on Android, we are using Kaltura SDK for some parts, and Exoplayer directly in older flows. |
Description of the Changes
This is an enhancement to add playback item URI to the standard PlayKit Playback Info.
CheckLists