Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playkit_IMA support for Picture in Picture #455

Open
audrarodriguez opened this issue Feb 24, 2022 · 4 comments
Open

Playkit_IMA support for Picture in Picture #455

audrarodriguez opened this issue Feb 24, 2022 · 4 comments
Assignees

Comments

@audrarodriguez
Copy link

audrarodriguez commented Feb 24, 2022

I've been trying to support ads for picture in picture using Kaltura SDK but it seems there's no way to support this via Playkit_IMA.

I've read some documentation about using Google IMA with picture in picture but it seems this documentation is not helping when trying to use Playkit_IMA with picture in picture.
Link for the documentation: https://developers.google.com/interactive-media-ads/docs/sdks/ios/client-side/picture_in_picture

My questions is, does Kaltura support ads via Playkit_IMA using picture in picture or is there other way in which this can be done?

@nidhik
Copy link

nidhik commented Mar 14, 2022

Bumping this issue. Please let us know if displaying (Google IMA) ads in picture in picture mode is supported by Kaltura.

@x-NR-x x-NR-x self-assigned this Mar 23, 2022
@x-NR-x
Copy link
Collaborator

x-NR-x commented Mar 23, 2022

Hello @audrarodriguez and @nidhik,

Thank you for contacting us, and sorry for the late response.
We have a sample of PiP in the samples repo (https://github.com/kaltura/playkit-ios-samples).

We haven't tried to combine IMA with it, I will create a task to check it.
In the meantime you are welcome to play around with it.

Thanks,
Nilit

@x-NR-x
Copy link
Collaborator

x-NR-x commented Mar 23, 2022

You have the following delegate in the IMAPlugin:
weak public var pipDelegate: AVPictureInPictureControllerDelegate?

  • Don't forget to set Background Modes to ON for Audio, AirPlay and Picture in Picture.
  • Set the AVAudioSession properties to support background playback:
[[AVAudioSession sharedInstance] setActive:YES error:nil];
[[AVAudioSession sharedInstance] setCategory:AVAudioSessionCategoryPlayback error:nil];
  • We already set the 'enableBackgroundPlayback' in the IMASettings to true as the default value.

@x-NR-x
Copy link
Collaborator

x-NR-x commented Mar 23, 2022

I see now that we have a bug there that we will need to fix in order for it to work.
Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants