feat(FEC-10783): create BP plugin #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
reviewed
Dec 23, 2020
OrenMe
reviewed
Dec 23, 2020
OrenMe
suggested changes
Dec 23, 2020
OrenMe
reviewed
Dec 23, 2020
OrenMe
previously approved these changes
Dec 27, 2020
dan-ziv
suggested changes
Dec 27, 2020
dan-ziv
reviewed
Dec 27, 2020
dan-ziv
reviewed
Dec 27, 2020
OrenMe
reviewed
Dec 29, 2020
OrenMe
previously approved these changes
Jan 17, 2021
dan-ziv
suggested changes
Jan 17, 2021
src/bp-engine-decorator.js
Outdated
| * @param {BroadPeak} plugin - The broadpeak plugin. | ||
| * @implements {IEngineDecorator} | ||
| */ | ||
| class BpEngineDecorator implements IEngineDecorator { |
There was a problem hiding this comment.
Kept it with BP instead of BroadPeak
There was a problem hiding this comment.
It's your call, but naming usually should be consistent and not change from file to file.
There was a problem hiding this comment.
It's, also middleware use the shortcut and once it was broadpeak smartlib it also used BP instead broadpeak
dan-ziv
suggested changes
Jan 18, 2021
There was a problem hiding this comment.
@Yuvalke LGTM but need to update README to integration with kaltura player and not playkit (plugins are now one level up -see here https://github.com/kaltura/playkit-js-airplay)
dan-ziv
reviewed
Jan 18, 2021
| The plugin requires [PlayKit JS Player] to be loaded first. | ||
|
|
||
| [playkit js player]: https://github.com/kaltura/playkit-js | ||
| The plugin requires [Kaltura Player JS] to be loaded first. |
There was a problem hiding this comment.
Title link is broken. need to add
[kaltura player js]: https://github.com/kaltura/kaltura-player-js
dan-ziv
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable to use of broadpeak smartlib as a plugin which replacing our source by source we're getting from broadpeak smartlib.