Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SUP-39906): pass error object in promise rejection #16

Merged
merged 1 commit into from Nov 13, 2023
Merged

fix(SUP-39906): pass error object in promise rejection #16

merged 1 commit into from Nov 13, 2023

Conversation

lianbenjamin
Copy link
Contributor

@lianbenjamin lianbenjamin commented Nov 12, 2023 •
edited by jira bot

Description of the Changes

Pass error object to promise rejection, when getUrl API fails.

Solves SUP-39906

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

SivanA-Kaltura
SivanA-Kaltura requested changes Nov 12, 2023
View reviewed changes
src/broadpeak.js Show resolved Hide resolved
@lianbenjamin lianbenjamin merged commit 4b9c8cc into master Nov 13, 2023
3 checks passed
@lianbenjamin lianbenjamin deleted the SUP-39906 branch November 13, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura approved these changes

@semarche-kaltura semarche-kaltura Awaiting requested review from semarche-kaltura

@JonathanTGold JonathanTGold Awaiting requested review from JonathanTGold

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lianbenjamin @SivanA-Kaltura