Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-11138): Remove player logs from console #2

Merged
merged 6 commits into from
Apr 12, 2021
Merged

fix(FEC-11138): Remove player logs from console #2

merged 6 commits into from
Apr 12, 2021

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Apr 12, 2021

Description of the Changes

Use BB log manager to determine log level for BB plugin.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Apr 12, 2021
OrenMe
OrenMe previously approved these changes Apr 12, 2021
View reviewed changes
@dan-ziv dan-ziv merged commit 3231556 into master Apr 12, 2021
@dan-ziv dan-ziv deleted the FEC-11138 branch April 12, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe left review comments

@yairans yairans Awaiting requested review from yairans

@Yuvalke Yuvalke Awaiting requested review from Yuvalke

@RoyBregman RoyBregman Awaiting requested review from RoyBregman

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @OrenMe