Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: finally doesn't support on IE11 #4

Merged
merged 3 commits into from
Apr 29, 2021
Merged

fix: finally doesn't support on IE11 #4

merged 3 commits into from
Apr 29, 2021

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Apr 27, 2021 •
edited
Loading

Description of the Changes

Add promise polyfill to solve the finally issue that exists on broadpeak SDK.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix: finally doesn't support on IE11
71467b4 
change finally catch/then
@Yuvalke Yuvalke requested a review from yairans April 27, 2021 14:28
@Yuvalke Yuvalke self-assigned this Apr 27, 2021
yairans
yairans previously approved these changes Apr 27, 2021
View reviewed changes
@yairans yairans self-requested a review April 29, 2021 12:35
@Yuvalke Yuvalke merged commit fa74117 into master Apr 29, 2021
@Yuvalke Yuvalke deleted the fix-promise branch April 29, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

Assignees

@Yuvalke Yuvalke

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Yuvalke @yairans