feat(FEC-10290): upgrade NPM packages #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 16, 2020 15:51
5 tasks
added 2 commits
July 20, 2020 18:29
OrenMe
reviewed
Jul 23, 2020
Yuvalke
reviewed
Jul 23, 2020
| @@ -13,7 +13,9 @@ | |||
| "should": true, | |||
| "sinon": true, | |||
| "__VERSION__": true, | |||
| "__NAME__": true | |||
| "__NAME__": true, | |||
| "process": true, | |||
There was a problem hiding this comment.
karma.config and webpack.config was removed from .eslintignore (eslint should lint those files too...) and they are using Node globals that you need to define to eslint so it won't detect them as errors.
added 2 commits
July 26, 2020 10:20
OrenMe
previously approved these changes
Jul 26, 2020
added 2 commits
July 26, 2020 21:55
…dash into upgrade-npm-packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
✅ eslint upgraded to 7.x.x
✅ babel upgraded to @babel (7.x.x)
✅ webpack upgraded to 4.x.x
CheckLists