Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-10766): create text config section and option for styling #124

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Dec 8, 2020

Description of the Changes

Issue: text track doesn't have a config for styling, there is only an API for styling.
Solution: create a text container for the text track and add the options for styling the text track.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Issue: text track don't have a config for styling, there is the only an API for styling.
Solution: create text container for text track and add the options for styling the text track
@Yuvalke Yuvalke requested a review from a team December 8, 2020 14:16
@Yuvalke Yuvalke self-assigned this Dec 8, 2020
@Yuvalke Yuvalke merged commit f4a56cf into master Dec 29, 2020
@Yuvalke Yuvalke deleted the FEC-10766 branch December 29, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants