fix(FEC-11126): upgrade shaka to 3.0.10 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyBregman
requested review from
yairans,
OrenMe,
Yuvalke and
dan-ziv
and removed request for
yairans and
OrenMe
5 tasks
dan-ziv
previously approved these changes
Apr 12, 2021
OrenMe
previously requested changes
Apr 12, 2021
yairans
suggested changes
Apr 12, 2021
src/dash-adapter.js
Outdated
| @@ -856,8 +858,10 @@ export default class DashAdapter extends BaseMediaSourceAdapter { | |||
| let parsedTracks = []; | |||
| if (textTracks) { | |||
| for (let i = 0; i < textTracks.length; i++) { | |||
| let kind = textTracks[i].kind ? textTracks[i].kind + 's' : ''; | |||
| kind = kind === '' && this._config.useShakaTextTrackDisplay ? 'smtpe-tt-captions' : kind; | |||
There was a problem hiding this comment.
Suggested change
| kind = kind === '' && this._config.useShakaTextTrackDisplay ? 'smtpe-tt-captions' : kind; | |
| kind = kind === '' && this._config.useShakaTextTrackDisplay ? 'smpte-tt-captions' : kind; |
src/dash-adapter.js
Outdated
| this._shaka && | ||
| textTrack instanceof TextTrack && | ||
| !textTrack.active && | ||
| (textTrack.kind === 'subtitles' || textTrack.kind === 'captions' || textTrack.kind === 'smtpe-tt-captions') |
There was a problem hiding this comment.
Suggested change
| (textTrack.kind === 'subtitles' || textTrack.kind === 'captions' || textTrack.kind === 'smtpe-tt-captions') | |
| (textTrack.kind === 'subtitles' || textTrack.kind === 'captions' || textTrack.kind === 'smpte-tt-captions') |
There was a problem hiding this comment.
['subtitles', 'captions', 'smpte-tt-captions'].includes(textTrack.kind)
yairans
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
SMPTE-TT Subtitles fix
depends on kaltura/kaltura-player-js#432
solves FEC-11126
CheckLists