Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-11409): many shaka warnings printed in the log #159

Merged
merged 3 commits into from
Jul 19, 2021
Merged

fix(FEC-11409): many shaka warnings printed in the log #159

merged 3 commits into from
Jul 19, 2021

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jul 14, 2021 •
edited
Loading

Description of the Changes

dont call shaka.getManifest where is not required

Solves FEC-11409

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

OrenMe
OrenMe reviewed Jul 14, 2021
View reviewed changes
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to check that it is ok for live.
I know shaka team asked to get examples of usage if getManifest, so worth checking if there are alternatives to some of the queries we do.

For example getSeekRangeEnd can be read from seekRange.end API

@yairans
Copy link
Contributor Author

yairans commented Jul 14, 2021

good point @OrenMe I've changed what is possible.
The only leftover is presentationTimeline.getSegmentAvailabilityEnd which not exposed by shaka player see shaka-project/shaka-player#2711

@yairans yairans changed the title fix(FEC-110409): many shaka warnings printed in the log fix(FEC-11409): many shaka warnings printed in the log Jul 14, 2021
@yairans yairans merged commit 51f7adf into master Jul 19, 2021
@yairans yairans deleted the FEC-11409 branch July 19, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@RoyBregman RoyBregman Awaiting requested review from RoyBregman

@JonathanTGold JonathanTGold Awaiting requested review from JonathanTGold

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @OrenMe