Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-12189): Stream doesn't start if open a program with a bookmark #194

Merged
merged 8 commits into from
Jun 26, 2022

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented Jun 12, 2022

Description of the Changes

solves: FEC-12189

related pr:
kaltura/playkit-js#652

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

src/dash-adapter.js Outdated Show resolved Hide resolved
SivanA-Kaltura
SivanA-Kaltura previously approved these changes Jun 14, 2022
Copy link
Contributor

@yairans yairans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add unit tests please

@kaltura kaltura deleted a comment from SivanA-Kaltura Jun 23, 2022
@kaltura kaltura deleted a comment from SivanA-Kaltura Jun 23, 2022
@JonathanTGold JonathanTGold requested review from SivanA-Kaltura and giladna and removed request for yairans June 23, 2022 13:09
@JonathanTGold JonathanTGold merged commit 305e772 into master Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants