Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-12539): Shaka text displayer font size too small on TVs #208

Merged
merged 3 commits into from
Sep 29, 2022
Merged

fix(FEC-12539): Shaka text displayer font size too small on TVs #208

merged 3 commits into from
Sep 29, 2022

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented Sep 29, 2022 •
edited
Loading

Description of the Changes

solves: FEC-12539 - Regression

issue: the previous fix is incorrect since the media query refers to the screen size and not the player size

fix: The :fullscreen CSS pseudo-class is not applied in samrtTvs, so instead i relying on the Env.IsSmartTv env variable

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@JonathanTGold JonathanTGold merged commit f224a1e into master Sep 29, 2022
giladna added a commit that referenced this pull request Sep 29, 2022
@giladna
Revert "fix(FEC-12539): Shaka text displayer font size too small on T…
ef09102 
…Vs (#208)"

This reverts commit f224a1e.
@giladna giladna mentioned this pull request Sep 29, 2022
Closed
@JonathanTGold JonathanTGold mentioned this pull request Oct 3, 2022
Merged
5 tasks
JonathanTGold added a commit that referenced this pull request Oct 3, 2022
@JonathanTGold
fix(FEC-12622): Revert - TV font size bug fixes - regression (#214)
1ef471b 
Revert - TV font size bug fixes - regression

revert all prsrelated to this bug: #208 #210 #205

solves: FEC-12622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladna giladna giladna approved these changes

@Yuvalke Yuvalke Awaiting requested review from Yuvalke

@SivanA-Kaltura SivanA-Kaltura Awaiting requested review from SivanA-Kaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JonathanTGold @giladna