Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-6968): loadstart issue #26

Merged
merged 2 commits into from
Aug 31, 2017
Merged

fix(FEC-6968): loadstart issue #26

merged 2 commits into from
Aug 31, 2017

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Aug 31, 2017 •
edited
Loading

Description of the Changes

Fix for
FEC-6968 - [Win10_Chrome][Player_V3] - Player is loading endlessly

THIS IS A TEMPORARY FIX AND SHOULD REVERTED when shaka will fix this:
shaka-project/shaka-player#961
see also:
shaka-project/shaka-player#880

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Aug 31, 2017
@dan-ziv dan-ziv requested review from OrenMe and yairans August 31, 2017 09:00
@dan-ziv dan-ziv merged commit 4246079 into master Aug 31, 2017
@dan-ziv dan-ziv deleted the loadstart-fix branch August 31, 2017 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

Assignees

@dan-ziv dan-ziv

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @yairans