feat: change media #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
suggested changes
Sep 30, 2017
| DashAdapter._logger.debug('destroy'); | ||
| super.destroy(); | ||
| this._loadPromise = null; | ||
| this._sourceObj = null; |
There was a problem hiding this comment.
any reason for not setting for null now? wasn't necessary?
There was a problem hiding this comment.
loadPromise is still setted to null,sourceObj is setted to null already in the base class.
yairans
previously approved these changes
Oct 1, 2017
|
@dan-ziv LGTM, but please fix tests |
added 6 commits
October 2, 2017 17:07
yairans
previously approved these changes
Oct 15, 2017
OrenMe
approved these changes
Oct 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Requires to change destroy API to return promises since shaka destroy API returns promise.
Needs to be merge after playkit-js PR will be merged.
CheckLists