fix(FEC-7476): error handling #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto error_handling_refactor asd the commit.
OrenMe
suggested changes
Nov 25, 2017
| @@ -217,7 +218,7 @@ export default class DashAdapter extends BaseMediaSourceAdapter { | |||
| */ | |||
| _removeBindings(): void { | |||
| this._shaka.removeEventListener('adaptation', this._onAdaptation); | |||
| this._shaka.removeEventListener('error', this._onError); | |||
| this._shaka.removeEventListener('error', this._onError.bind(this)); | |||
There was a problem hiding this comment.
use arrow function () => this._onError
There was a problem hiding this comment.
@OrenMe - so i will change all of the bindings...
ignoring video tag errors
…nto error_handling_refactor
dan-ziv
suggested changes
Dec 6, 2017
src/dash-adapter.js
Outdated
| @@ -3,6 +3,7 @@ import shaka from 'shaka-player'; | |||
| import {BaseMediaSourceAdapter} from 'playkit-js' | |||
| import {Track, VideoTrack, AudioTrack, TextTrack} from 'playkit-js' | |||
| import {Utils} from 'playkit-js' | |||
| import {Error, Severity} from 'playkit-js' | |||
There was a problem hiding this comment.
Why do we need separate class for Severity?
As I see it, it should be a static prop on the Error class.
Error.Severity.CRITICAL
src/dash-adapter.js
Outdated
| reject(error); | ||
| this._onError(error); | ||
| reject(new Error( | ||
| error.everity.CRITICAL, |
odedhutzler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Firing an error from the dash adapter, ignoring video element errors.
CheckLists