Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build #43

Merged
merged 3 commits into from
Jan 28, 2018
Merged

fix: build #43

merged 3 commits into from
Jan 28, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Jan 28, 2018

Description of the Changes

Fix the build.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Jan 28, 2018
@dan-ziv dan-ziv requested a review from yairans January 28, 2018 15:07
yairans
yairans previously approved these changes Jan 28, 2018
View reviewed changes
@dan-ziv dan-ziv merged commit a632a7e into master Jan 28, 2018
@dan-ziv dan-ziv deleted the fix-build branch January 28, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans left review comments

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @yairans