Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8130): typo in adaptation event listener #52

Merged
merged 2 commits into from
May 6, 2018
Merged

fix(FEC-8130): typo in adaptation event listener #52

merged 2 commits into from
May 6, 2018

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Apr 18, 2018 •
edited
Loading

Description of the Changes

Event listener had a typo, and some other places, causing adaptation event to not be handled.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe self-assigned this Apr 18, 2018
dan-ziv
dan-ziv previously approved these changes Apr 18, 2018
View reviewed changes
@dan-ziv dan-ziv merged commit 31f9101 into master May 6, 2018
@dan-ziv dan-ziv deleted the FEC-8130 branch May 6, 2018 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

@odedhutzler odedhutzler Awaiting requested review from odedhutzler

Assignees

@OrenMe OrenMe

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OrenMe @dan-ziv