fix(FEC-7935): fix text selection logic #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ording to `useNativeTextTrack` config flag
dan-ziv
previously approved these changes
Jul 11, 2018
yairans
reviewed
Jul 12, 2018
| @@ -493,6 +495,7 @@ export default class DashAdapter extends BaseMediaSourceAdapter { | |||
| */ | |||
| selectTextTrack(textTrack: TextTrack): void { | |||
| if (this._shaka && (textTrack instanceof TextTrack) && !textTrack.active && (textTrack.kind === 'subtitles' || textTrack.kind === 'captions')) { | |||
| this._shaka.setTextTrackVisibility(this._config.textTrackVisibile); | |||
There was a problem hiding this comment.
better to set it on init as before.
There was a problem hiding this comment.
we need it here, because for when calling hideTextTracks, e.g. setting them OFF, we call setTextTrackVisibility(false) so we need to always toggle it back.
There's no option in Shaka API to set subtitle OFF, just setting the display mode, so we have to call it when setting text track display of selectTextTrack
yairans
previously approved these changes
Jul 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
use shaka
setTextTrackVisibilityto set text track display mode according touseNativeTextTrackconfig flag.This change is part of kaltura/playkit-js-hls#65 and kaltura/playkit-js#263 - removing the overhead of handling in playkit-js is possible by using the Shaka APIs to set track visibility.
CheckLists