fix(FEC-7590): filter Shaka audio tracks by language and not bitrate #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no need to ID and setting the active, it is set by the player. using getAudioLanguagesAndRoles() to get the list of languages from shaka.
dan-ziv
suggested changes
Jul 30, 2018
src/dash-adapter.js
Outdated
| @@ -409,8 +414,6 @@ export default class DashAdapter extends BaseMediaSourceAdapter { | |||
| if (audioTracks) { | |||
| for (let i = 0; i < audioTracks.length; i++) { | |||
| let settings = { | |||
| id: audioTracks[i].id, | |||
| active: audioTracks[i].active, | |||
| label: audioTracks[i].label, | |||
There was a problem hiding this comment.
@dan-ziv, because it's not relevant here. We now create the number of audio tracks based on the number of languages. (shaka selects an audio track based on the language)
I can leave the id and active flag of the variant, but this data will become stale when/if we change the bitrate of the video.
currently, we have no use of this data, so it can be removed
active - variant value id - concatonation of all the variants id's
OrenMe
suggested changes
Jul 31, 2018
| return variantTrack.videoId === activeVariantTrack.videoId; | ||
| const variantTracks = this._shaka.getVariantTracks(); | ||
| let audioTracks = this._shaka.getAudioLanguagesAndRoles(); | ||
| audioTracks.forEach(track => { |
There was a problem hiding this comment.
A more functional way to do it is:
audioTracks.forEach(track => {
const sameLangAudioVariants = variantTracks.filter(vt=>vt.language === t.language);
const id = sameLangAudioVariants.map(t=>t.id).join('_');
const active = sameLangAudioVariants.some(t=>t.active);
track.id = id;
track.label = sameLangAudioVariants[0].label ;
track.active = active;
});
odedhutzler
changed the title
OrenMe
approved these changes
Jul 31, 2018
5 tasks
OrenMe
added a commit
that referenced
this pull request
Aug 11, 2018
Use our own stream for VoD testing.
Fix async tests that don't have catch clauses:
```javascript
Promise.then().catch(e => {done(e))
try { ... } catch (e) { done(e); }
```
Fix failing audio tests following #58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
creating an audio track array of unique languages
no need to ID and setting the active, it is set by the player.
using getAudioLanguagesAndRoles() to get the list of languages from shaka.
CheckLists