Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8666): cannot play dash drm #65

Merged
merged 2 commits into from
Nov 8, 2018
Merged

fix(FEC-8666): cannot play dash drm #65

merged 2 commits into from
Nov 8, 2018

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Nov 8, 2018 •
edited
Loading

Description of the Changes

shaka config drm is not updated. sent config._shakaConfig to the setDrmPlayback() function, instead of the config object.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler odedhutzler self-assigned this Nov 8, 2018
OrenMe
OrenMe reviewed Nov 8, 2018
View reviewed changes
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is also needed in _setShakaConfig

@odedhutzler odedhutzler changed the title fix(FEC-8666): fix(FEC-8666): cannot play dash drm Nov 8, 2018
@odedhutzler odedhutzler merged commit 8d724ac into master Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@odedhutzler odedhutzler

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@odedhutzler @OrenMe