Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-9316): seek doesn't work before video finished loading #87

Merged
merged 2 commits into from
Oct 24, 2019

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Oct 16, 2019

Description of the Changes

occurred on DRM content only LOAD_DATA on SMART TV could take a moment and user can seek before - check if SEEKED event occurred before.
Couldn't resolve with LOADED_METADATA seek failed on earlier version of TV.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

LOAD_DATA on SMART TV could take a moment and user can seek before, than check if SEEKED event occured before.
Could resolve with LOADED_METADATA - should check on earlier version of TV if it's possible cause there was an issue with seek on LOADED_METADATA event
@Yuvalke Yuvalke self-assigned this Oct 16, 2019
@Yuvalke Yuvalke requested review from OrenMe, yairans and a team and removed request for OrenMe and yairans October 16, 2019 11:04
@Yuvalke Yuvalke merged commit c498d4d into master Oct 24, 2019
@Yuvalke Yuvalke deleted the FEC-9316 branch October 24, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants