Skip to content

Commit

Permalink
fix(FEC-13022): fix link and selection accessibility (#740)
Browse files Browse the repository at this point in the history
solves FEC-13022
  • Loading branch information
JonathanTGold committed Mar 15, 2023
1 parent fb7159a commit 10ddcc8
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 6 deletions.
3 changes: 1 addition & 2 deletions src/components/icon/icon.scss
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@

// Dynamic Colored Icons
.player {
--playkit-icon-check-active-url: #{icon(check, $brand-color)};
--playkit-icon-vr-stereo-full-url: #{icon(vrStereoFull, $brand-color)};
--playkit-icon-chromecast-url: #{icon(chromecast, $brand-color)};
--playkit-icon-quality-HD-active-url: #{icon(qualityHdActive, $brand-color, '16', '0 0 16 16')};
Expand Down Expand Up @@ -197,7 +196,7 @@
}

.icon-check-active {
background-image: var(--playkit-icon-check-active-url);
background-image: icon(check, '#fff');
}

.icon-language {
Expand Down
2 changes: 1 addition & 1 deletion src/components/language/_language.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.player {
a:not([href]) {
&.advanced-captions-menu-link {
color: $primary-brighter-color;
color: $tone-1-color;
text-decoration: underline;
}
}
Expand Down
2 changes: 0 additions & 2 deletions src/styles/_dropdown.scss
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,6 @@
}

&.active {
color: $primary-color;

.menu-icon-container {
opacity: 1;
}
Expand Down
1 change: 0 additions & 1 deletion src/utils/themes-manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const cssVarNames = {
const ACCENT_AND_ACKNOWLEDGEMENT_COLORS = ['primary', 'secondary', 'success', 'danger', 'warning'];

const dynamicColoredIconsSvgUrlVars = [
'--playkit-icon-check-active-url',
'--playkit-icon-data-url',
'--playkit-icon-chromecast-url',
'--playkit-icon-quality-HD-active-url',
Expand Down

0 comments on commit 10ddcc8

Please sign in to comment.