Skip to content

Commit

Permalink
feat(FEC-10287): on 'Picture in picture' mode, the tooltip shall be "…
Browse files Browse the repository at this point in the history
…expand” instead of "Exit pictures in pictures" (#625)

on 'Picture in picture' mode, the tooltip shall be “expand” instead of "Exit pictures in pictures"
  • Loading branch information
JonathanTGold committed Jul 19, 2021
1 parent a81f08f commit 1c9c1d6
Show file tree
Hide file tree
Showing 18 changed files with 20 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/components/picture-in-picture/picture-in-picture.js
Expand Up @@ -42,7 +42,8 @@ const COMPONENT_NAME = 'PictureInPicture';
@withEventDispatcher(COMPONENT_NAME)
@withText({
pictureInPictureText: 'controls.pictureInPicture',
pictureInPictureExitText: 'controls.pictureInPictureExit'
pictureInPictureExitText: 'controls.pictureInPictureExit',
pictureInPictureExpandText: 'controls.pictureInPictureExpand'
})
class PictureInPicture extends Component {
_keyboardEventHandlers: Array<KeyboardEventHandlers> = [
Expand Down Expand Up @@ -96,7 +97,7 @@ class PictureInPicture extends Component {
if (this.props.isPictureInPictureSupported && this.props.playerSize !== PLAYER_SIZE.EXTRA_SMALL) {
return (
<ButtonControl name={COMPONENT_NAME}>
<Tooltip label={this.props.isInPictureInPicture ? this.props.pictureInPictureExitText : this.props.pictureInPictureText}>
<Tooltip label={this.props.isInPictureInPicture ? this.props.pictureInPictureExpandText : this.props.pictureInPictureText}>
<Button
tabIndex="0"
aria-label={this.props.isInPictureInPicture ? this.props.pictureInPictureExitText : this.props.pictureInPictureText}
Expand Down
1 change: 1 addition & 0 deletions translations/ar.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "البدء من جديد",
"pictureInPicture": "صورة داخل صورة",
"pictureInPictureExit": "الخروج من وضع صورة داخل صورة",
"pictureInPictureExpand": "توسيع",
"logo": "الشعار",
"seekBarSlider": "شريط تمرير الانتقال"
},
Expand Down
1 change: 1 addition & 0 deletions translations/de.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "Von vorne",
"pictureInPicture": "Bild im Bild",
"pictureInPictureExit": "Bild im Bild verlassen",
"pictureInPictureExpand": "Erweitern",
"logo": "Logo",
"seekBarSlider": "Suchleiste"
},
Expand Down
1 change: 1 addition & 0 deletions translations/en.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "Start over",
"pictureInPicture": "Picture in picture",
"pictureInPictureExit": "Exit picture in picture",
"pictureInPictureExpand": "Expand",
"logo": "Logo",
"seekBarSlider": "Seek slider"
},
Expand Down
1 change: 1 addition & 0 deletions translations/es.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "Volver a empezar",
"pictureInPicture": "Imagen dentro de la imagen",
"pictureInPictureExit": "Cerrar imagen dentro de la imagen",
"pictureInPictureExpand": "Expandir",
"logo": "Logotipo",
"seekBarSlider": "Buscar control deslizante"
},
Expand Down
1 change: 1 addition & 0 deletions translations/fi.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "Aloita uudelleen",
"pictureInPicture": "Kuva kuvassa",
"pictureInPictureExit": "Poistu kuva kuvassa -tilasta",
"pictureInPictureExpand": "Laajenna",
"logo": "Logo",
"seekBarSlider": "Hae liukusäädin"
},
Expand Down
1 change: 1 addition & 0 deletions translations/fr.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "Recommencer",
"pictureInPicture": "Image dans l’image",
"pictureInPictureExit": "Quitter Image dans l’image",
"pictureInPictureExpand": "Agrandir",
"logo": "Logo",
"seekBarSlider": "Diapositive"
},
Expand Down
1 change: 1 addition & 0 deletions translations/fr_ca.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "Recommencer",
"pictureInPicture": "Picture-in-picture",
"pictureInPictureExit": "Fermer le mode Picture-in-picture",
"pictureInPictureExpand": "RETOUR (au mode normal)",
"logo": "Logo",
"seekBarSlider": "Curseur"
},
Expand Down
1 change: 1 addition & 0 deletions translations/he.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "התחל מחדש",
"pictureInPicture": "תמונה בתוך תמונה",
"pictureInPictureExit": "צא מתמונה מתוך תמונה",
"pictureInPictureExpand": "הרחב",
"logo": "לוגו",
"seekBarSlider": "חפש מחוון"
},
Expand Down
1 change: 1 addition & 0 deletions translations/hi_in.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "प्रारंभ करें",
"pictureInPicture": "पिक्चर इन पिक्चर",
"pictureInPictureExit": "तस्वीर में प्रस्थान तस्वीर",
"pictureInPictureExpand": "विस्तृत करें",
"logo": "लोगो",
"seekBarSlider": "स्लाइडर के लिए प्रयास करें"
},
Expand Down
1 change: 1 addition & 0 deletions translations/it.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "Riavvia",
"pictureInPicture": "Immagine nell’immagine",
"pictureInPictureExit": "Esci dall'immagine nell'immagine",
"pictureInPictureExpand": "Ingrandisci",
"logo": "Logo",
"seekBarSlider": "Cursore di ricerca"
},
Expand Down
1 change: 1 addition & 0 deletions translations/ja.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "最初から再生する",
"pictureInPicture": "ピクチャーインピクチャー",
"pictureInPictureExit": "ピクチャーインピクチャーを終了",
"pictureInPictureExpand": "拡大",
"logo": "ロゴ",
"seekBarSlider": "シーク スライダー"
},
Expand Down
1 change: 1 addition & 0 deletions translations/ko.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "처음부터 재생",
"pictureInPicture": "화면 속 화면",
"pictureInPictureExit": "화면 속 화면 나가기",
"pictureInPictureExpand": "확장",
"logo": "로고",
"seekBarSlider": "슬라이더"
},
Expand Down
1 change: 1 addition & 0 deletions translations/nl.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "Opnieuw beginnen",
"pictureInPicture": "Beeld in beeld",
"pictureInPictureExit": "Beeld in beeld afsluiten",
"pictureInPictureExpand": "Uitbreiden",
"logo": "Logo",
"seekBarSlider": "Zoekschuifregelaar"
},
Expand Down
1 change: 1 addition & 0 deletions translations/pt_br.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "Começar de novo",
"pictureInPicture": "Picture in picture",
"pictureInPictureExit": "Sair do Picture in picture",
"pictureInPictureExpand": "Expandir",
"logo": "Logo",
"seekBarSlider": "Controle deslizante"
},
Expand Down
1 change: 1 addition & 0 deletions translations/ru.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "Запустить заново",
"pictureInPicture": "Картинка в картинке",
"pictureInPictureExit": "Выйти из второго канала",
"pictureInPictureExpand": "Развернуть",
"logo": "Логотип",
"seekBarSlider": "Слайдер навигации"
},
Expand Down
1 change: 1 addition & 0 deletions translations/zh_cn.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "重新开始",
"pictureInPicture": "画中画",
"pictureInPictureExit": "退出画中画",
"pictureInPictureExpand": "",
"logo": "标识",
"seekBarSlider": "搜寻滑块"
},
Expand Down
1 change: 1 addition & 0 deletions translations/zh_tw.i18n.json
Expand Up @@ -18,6 +18,7 @@
"startOver": "重頭",
"pictureInPicture": "圖片中的圖片",
"pictureInPictureExit": "退出圖片中的圖片",
"pictureInPictureExpand": "擴展",
"logo": "圖標",
"seekBarSlider": "進行輪播"
},
Expand Down

0 comments on commit 1c9c1d6

Please sign in to comment.