feat(FEC-9613): allow application to disable double-click to fullscre…

…en (#513) * add `ui.components.fullscreen.disableDoubleClick` config and use it in the overlay-action component * add missing component config types
kaltura · Jun 2, 2020 · 2d9df3b · 2d9df3b
1 parent 7057e62
commit 2d9df3b
Show file tree

Hide file tree

Showing 6 changed files with 39 additions and 17 deletions.
diff --git a/flow-typed/types/components-config.js b/flow-typed/types/components-config.js
@@ -2,5 +2,8 @@
 declare type ComponentsConfig = {
   seekbar?: SeekbarConfig,
   watermark?: WatermarkConfig,
-  share?: ShareConfig
+  share?: ShareConfig,
+  vrStereo?: VrStereoConfig,
+  logo?: LogoConfig,
+  fullscreen?: FullscreenConfig
 };
diff --git a/flow-typed/types/fullscreen-config.js b/flow-typed/types/fullscreen-config.js
@@ -0,0 +1,4 @@
+// @flow
+declare type FullscreenConfig = {
+  disableDoubleClick: boolean
+};
diff --git a/flow-typed/types/logo-config.js b/flow-typed/types/logo-config.js
@@ -0,0 +1,6 @@
+// @flow
+declare type LogoConfig = {
+  text: string,
+  url: string,
+  img: string
+};
diff --git a/flow-typed/types/vr-stereo-config.js b/flow-typed/types/vr-stereo-config.js
@@ -0,0 +1,4 @@
+// @flow
+declare type VrStereoConfig = {
+  vrStereoMode: boolean
+};
diff --git a/src/components/overlay-action/overlay-action.js b/src/components/overlay-action/overlay-action.js
@@ -21,7 +21,8 @@ const mapStateToProps = state => ({
   iconType: state.overlayAction.iconType,
   playerHover: state.shell.playerHover,
   isMobile: state.shell.isMobile,
-  isSmartContainerOpen: state.shell.smartContainerOpen
+  isSmartContainerOpen: state.shell.smartContainerOpen,
+  fullscreenConfig: state.config.components.fullscreen
 });
 
 /**
@@ -181,21 +182,24 @@ class OverlayAction extends Component {
     if (this.props.isSmartContainerOpen) {
       return;
     }
-    const now = Date.now();
-    if (now - this._firstClickTime < PLAY_PAUSE_BUFFER_TIME) {
-      this.cancelClickTimeout();
-      this.toggleFullscreen();
-      return;
-    }
-    if (now - this._firstClickTime < DOUBLE_CLICK_MAX_BUFFER_TIME) {
-      this.cancelClickTimeout();
-      this.togglePlayPause();
-      this.toggleFullscreen();
-      this._firstClickTime = 0;
-      return;
-    }
+    const {disableDoubleClick} = this.props.fullscreenConfig;
+    if (!disableDoubleClick) {
+      const now = Date.now();
+      if (now - this._firstClickTime < PLAY_PAUSE_BUFFER_TIME) {
+        this.cancelClickTimeout();
+        this.toggleFullscreen();
+        return;
+      }
+      if (now - this._firstClickTime < DOUBLE_CLICK_MAX_BUFFER_TIME) {
+        this.cancelClickTimeout();
+        this.togglePlayPause();
+        this.toggleFullscreen();
+        this._firstClickTime = 0;
+        return;
+      }
 
-    this._firstClickTime = now;
+      this._firstClickTime = now;
+    }
     this._clickTimeout = setTimeout(() => {
       this._clickTimeout = null;
       this.togglePlayPause();

diff --git a/src/reducers/config.js b/src/reducers/config.js
@@ -14,7 +14,8 @@ export const initialState = {
     seekbar: {},
     vrStereo: {},
     share: {},
-    logo: {}
+    logo: {},
+    fullscreen: {}
   }
 };