Skip to content

Commit

Permalink
feat(FEC-9029): unable to set the Smart Container titles (#383)
Browse files Browse the repository at this point in the history
Added the option to alter the Smart Container titles on `settings` and `languages'
  • Loading branch information
Shalom Meoded authored and OrenMe committed Apr 30, 2019
1 parent ba1210d commit 433a994
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/components/language/language.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ class LanguageControl extends BaseComponent {
{!this.state.smartContainerOpen || this.state.cvaaOverlay ? (
undefined
) : (
<SmartContainer targetId={this.player.config.targetId} title="Language" onClose={() => this.onControlButtonClick()}>
<SmartContainer targetId={this.player.config.targetId} title={<Text id="language.title" />} onClose={() => this.onControlButtonClick()}>
{audioOptions.length <= 1 ? (
undefined
) : (
Expand Down
2 changes: 1 addition & 1 deletion src/components/settings/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ class SettingsControl extends BaseComponent {
{!this.state.smartContainerOpen ? (
''
) : (
<SmartContainer targetId={this.player.config.targetId} title="Settings" onClose={() => this.onControlButtonClick()}>
<SmartContainer targetId={this.player.config.targetId} title={<Text id="settings.title" />} onClose={() => this.onControlButtonClick()}>
{qualityOptions.length <= 1 ? (
''
) : (
Expand Down
2 changes: 2 additions & 0 deletions src/translations/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,12 @@
"button": "Copy"
},
"settings": {
"title": "Settings",
"quality": "Quality",
"speed": "Speed"
},
"language": {
"title": "Language",
"audio": "Audio",
"captions": "Captions",
"advanced_captions_settings": "Advanced captions settings"
Expand Down

0 comments on commit 433a994

Please sign in to comment.