fix(FEC-10472): spinner doesn't show up (#541)

Issue: props didn't pass correctly to cloneElement since it has changed on the last upgrade. Solution: use cloneElement correctly and remove @babel/plugin-transform-spread which doesn't need anymore.
kaltura · Sep 7, 2020 · 56a6ea7 · 56a6ea7
1 parent 03ed799
commit 56a6ea7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 14 deletions.
diff --git a/.babelrc b/.babelrc
@@ -12,12 +12,6 @@
     "@babel/plugin-transform-flow-strip-types",
     "@babel/plugin-transform-property-mutators",
     "@babel/plugin-proposal-object-rest-spread",
-    [
-      "@babel/plugin-transform-spread",
-      {
-        "loose": true
-      }
-    ],
     [
       "@babel/plugin-proposal-decorators",
       {

diff --git a/package.json b/package.json
@@ -52,7 +52,6 @@
     "@babel/plugin-transform-modules-commonjs": "^7.10.4",
     "@babel/plugin-transform-property-mutators": "^7.10.4",
     "@babel/plugin-transform-react-jsx": "^7.10.4",
-    "@babel/plugin-transform-spread": "^7.10.4",
     "@babel/preset-env": "^7.10.4",
     "@babel/preset-flow": "^7.10.4",
     "@babel/register": "^7.10.5",

diff --git a/src/components/smart-container/smart-container.js b/src/components/smart-container/smart-container.js
@@ -123,15 +123,12 @@ class SmartContainer extends Component {
   renderChildren(props: any): React$Element<any> {
     const children = toChildArray(props.children).map(child => {
       if (child) {
-        return cloneElement(
-          child,
-          {
-            pushRef: ref => {
-              props.addAccessibleChild(ref);
-            }
+        return cloneElement(child, {
+          pushRef: ref => {
+            props.addAccessibleChild(ref);
           },
           ...this.props
-        );
+        });
       }
     });
     return children;