Skip to content

Commit

Permalink
fix(FEC-8144, FEC-8024): black screen once seeking ie11 (#233)
Browse files Browse the repository at this point in the history
order the bottom bar elements correctly and as a result remove unnecessary z-index
  • Loading branch information
yairans authored and Dan Ziv committed May 6, 2018
1 parent 0ed9cd7 commit 7fc9a3f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
1 change: 1 addition & 0 deletions src/components/bottom-bar/_bottom-bar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
position: absolute;
bottom: 0;
left: 0;
z-index: 1;

.left-controls {
float: left;
Expand Down
5 changes: 0 additions & 5 deletions src/components/seekbar/_seekbar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
top: 0;
left: 0;
height: 100%;
z-index: 2;
border-radius: $progress-bar-border-radius 0 0 $progress-bar-border-radius;
background-color: $brand-color;
}
Expand All @@ -59,13 +58,11 @@
top: 0;
left: 0;
height: 100%;
z-index: 1;
border-radius: $progress-bar-border-radius 0 0 $progress-bar-border-radius;
background-color: rgba(255, 255, 255, 0.3);
}
.scrubber {
position: absolute;
z-index: 3;
cursor: pointer;
display: block;
top: -8px + $progress-bar-height / 2;
Expand Down Expand Up @@ -93,7 +90,6 @@
width: 164px;
border: 2px solid rgba(255, 255, 255, 0.2);
border-radius: 4px;
z-index: 10;

.frame-preview-img {
background-size: auto 100%;
Expand All @@ -107,7 +103,6 @@
position: absolute;
bottom: $progress-bar-height + 18px;
left: 0;
z-index: 11;
height: 22px;
min-width: 48px;
padding: 0 3px;
Expand Down
8 changes: 4 additions & 4 deletions src/components/seekbar/seekbar.js
Original file line number Diff line number Diff line change
Expand Up @@ -492,15 +492,15 @@ class SeekBarControl extends Component {
onTouchEnd={() => this.onSeekbarTouchEnd()}
onKeyDown={(e) => this.onSeekbarKeyDown(e)}>
<div className={style.progressBar}>
{this.renderFramePreview()}
{this.renderTimeBubble()}
<div className={style.virtualProgress} style={{width: virtualProgressWidth}}/>
<div className={style.buffered} style={{width: bufferedWidth}}/>
<div className={style.progress} style={{width: progressWidth}}>
{
props.adBreak ? undefined : <a className={style.scrubber}/>
}
</div>
<div className={style.virtualProgress} style={{width: virtualProgressWidth}}/>
{this.renderTimeBubble()}
{this.renderFramePreview()}
<div className={style.buffered} style={{width: bufferedWidth}}/>
</div>
</div>
)
Expand Down

0 comments on commit 7fc9a3f

Please sign in to comment.