Skip to content

Commit

Permalink
fix(FEC-9980): custom preset controls are continuously blinking on ho…
Browse files Browse the repository at this point in the history
…vering the bottom bar (#497)

Problem: Once the hovering timeout is done the shell is updating the store with playerHover:false which causes a renderer, but at this time the mouse is still hovering the shell so in onMouseOver the shell is updating the store with playerHover:true, and so on for ever...
(This reproduce in the preact version 8.x (current) only when custom preset is set, but in preactX even with our default presets)

Solution: remove the state updating from onMouseOver as it's redundant since onMouseMove

Solves: FEC-9980
  • Loading branch information
yairans committed Apr 20, 2020
1 parent b89acc4 commit 936bbda
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/components/shell/shell.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,6 @@ class Shell extends Component {
this.setState({nav: false});
this.props.updatePlayerNavState(false);
}
if (!this.props.bottomBarHoverActive) {
this._updatePlayerHoverState();
}
}

/**
Expand Down

0 comments on commit 936bbda

Please sign in to comment.