fix(FEC-8843): handle click outside when the menu is open (#366)

when menus are open - just close the menu, dont play/pause as well
kaltura · May 6, 2019 · 9820c35 · 9820c35
1 parent 3d07217
commit 9820c35
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/components/menu/menu.js b/src/components/menu/menu.js
@@ -118,7 +118,6 @@ class Menu extends Component {
       this._menuElement &&
       !this._menuElement.contains(e.target)
     ) {
-      e.stopPropagation();
       this.props.onClose();
     }
   }

diff --git a/src/components/overlay-action/overlay-action.js b/src/components/overlay-action/overlay-action.js
@@ -18,7 +18,8 @@ const mapStateToProps = state => ({
   isPlayingAdOrPlayback: isPlayingAdOrPlayback(state.engine),
   iconType: state.overlayAction.iconType,
   playerHover: state.shell.playerHover,
-  isMobile: state.shell.isMobile
+  isMobile: state.shell.isMobile,
+  isSmartContainerOpen: state.shell.smartContainerOpen
 });
 
 /**
@@ -179,6 +180,9 @@ class OverlayAction extends BaseComponent {
    * @memberof OverlayAction
    */
   overlayClick(): void {
+    if (this.props.isSmartContainerOpen) {
+      return;
+    }
     const now = Date.now();
     if (now - this._firstClickTime < PLAY_PAUSE_BUFFER_TIME) {
       this.cancelClickTimeout();