fix: replay button is missing after postroll (#282)

Rollback the addition of isEnded to isPlayingAdOrPlayback that caused the issue. Add updates to isPlaying and isPaused on ENDED event.
kaltura · Oct 14, 2018 · a17a280 · a17a280
1 parent d31d0aa
commit a17a280
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/components/engine-connector/engine-connector.js b/src/components/engine-connector/engine-connector.js
@@ -95,7 +95,6 @@ class EngineConnector extends BaseComponent {
       this.props.updateIsLive(this.player.isLive());
       this.props.updateIsDvr(this.player.isDvr());
       this.props.updatePlayerPoster(this.player.poster);
-      this.props.updateIsEnded(false);
     });
 
     this.eventManager.listen(this.player, this.player.Event.VOLUME_CHANGE, () => {
@@ -121,6 +120,8 @@ class EngineConnector extends BaseComponent {
 
     this.eventManager.listen(this.player, this.player.Event.ENDED, () => {
       this.props.updateIsEnded(true);
+      this.props.updateIsPlaying(false);
+      this.props.updateIsPaused(true);
     });
 
     this.eventManager.listen(this.player, this.player.Event.TRACKS_CHANGED, () => {
@@ -151,7 +152,6 @@ class EngineConnector extends BaseComponent {
     this.eventManager.listen(this.player, this.player.Event.AD_BREAK_START, () => {
       this.props.updateHasError(false);
       this.props.updateAdBreak(true);
-      this.props.updateIsEnded(false);
     });
 
     this.eventManager.listen(this.player, this.player.Event.AD_BREAK_END, () => {

diff --git a/src/reducers/getters.js b/src/reducers/getters.js
@@ -5,5 +5,5 @@
  * @returns {boolean} - Whether the player is playing ad or content.
  */
 export const isPlayingAdOrPlayback = (state: Object) => {
-  return !state.isEnded && ((state.adBreak && state.adIsPlaying) || (!state.adBreak && state.isPlaying));
+  return (state.adBreak && state.adIsPlaying) || (!state.adBreak && state.isPlaying);
 };