Skip to content

Commit

Permalink
fix(FEC-8269): pre-playback overlay is displayed when loop (#265)
Browse files Browse the repository at this point in the history
always update IsEnded to false on PLAY
  • Loading branch information
yairans committed Aug 6, 2018
1 parent a7409a0 commit a29ebaa
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
5 changes: 1 addition & 4 deletions src/components/engine-connector/engine-connector.js
Expand Up @@ -101,10 +101,7 @@ class EngineConnector extends BaseComponent {

this.eventManager.listen(this.player, this.player.Event.PLAY, () => {
this.props.updateIsPlaying(true);

if (this.props.engine.isEnded) {
this.props.updateIsEnded(false);
}
this.props.updateIsEnded(false);
});

this.eventManager.listen(this.player, this.player.Event.PAUSE, () => {
Expand Down
3 changes: 2 additions & 1 deletion src/components/volume/volume.js
Expand Up @@ -4,6 +4,7 @@ import {h} from 'preact';
import {connect} from 'preact-redux';
import {bindActions} from '../../utils/bind-actions';
import {actions} from '../../reducers/volume';
import {actions as engineActions} from '../../reducers/engine';
import BaseComponent from '../base';
import {default as Icon, IconType} from '../icon';
import {KeyMap} from '../../utils/key-map';
Expand All @@ -24,7 +25,7 @@ const mapStateToProps = state => ({

@connect(
mapStateToProps,
bindActions(actions)
bindActions({...actions, ...engineActions})
)
/**
* VolumeControl component
Expand Down

0 comments on commit a29ebaa

Please sign in to comment.