fix(FEC-9177): Smart TV showed as mobile device (#389)

Change every check of device.type to mobile or tablet instead, there are more device types which not relevant.
kaltura · Jun 11, 2019 · ab5b905 · ab5b905
1 parent 1f5d820
commit ab5b905
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/components/shell/shell.js b/src/components/shell/shell.js
@@ -200,7 +200,7 @@ class Shell extends BaseComponent {
    * @memberof Shell
    */
   componentDidMount() {
-    this.props.updateIsMobile(!!this.player.env.device.type || this.props.forceTouchUI);
+    this.props.updateIsMobile(this.player.env.isTablet || this.player.env.isMobile || this.props.forceTouchUI);
     this._onWindowResize();
     this.eventManager.listen(this.player, this.player.Event.RESIZE, () => this._onWindowResize());
     this.eventManager.listen(this.player, this.player.Event.FIRST_PLAY, () => this._onWindowResize());

diff --git a/src/ui-presets/ads.js b/src/ui-presets/ads.js
@@ -84,10 +84,10 @@ function getAdsUiCustomization(): Object {
  * @returns {boolean} - Whether the default ads ui should be shown or not.
  */
 function useDefaultAdsUi(props: any): boolean {
-  let isMobile = !!props.player.env.device.type;
+  const isMobile = props.state.shell.isMobile;
   let useStyledLinearAds = false;
   try {
-    let adsRenderingSettings = props.player.config.plugins.ima.adsRenderingSettings;
+    const adsRenderingSettings = props.player.config.plugins.ima.adsRenderingSettings;
     useStyledLinearAds = adsRenderingSettings && adsRenderingSettings.useStyledLinearAds;
   } catch (e) {
     // Do nothing