fix(FEC-9746): menu bar buttons ignores clicking if another menu is o…

…pen (#484)

The main fix is removing event.stopPropagation from line 120 in menu.js.
Removed the useCapture true in the addEventListener and replaced it with eventManager listen
Removed redundant code in settings.js and language.js

src/components/language/language.js

@@ -136,9 +136,6 @@ class Language extends Component {
       !this.state.cvaaOverlay &&
       !this.props.isSmallSize
     ) {
-      if (e.target.classList.contains('overlay-action')) {
-        e.stopPropagation();
-      }
       this.setState({smartContainerOpen: false});
     }
   }

src/components/menu/menu.js

@@ -64,22 +64,13 @@ class Menu extends Component {
    * @memberof Menu
    */
   componentDidMount() {
-    document.addEventListener('click', this.handleClickOutside, true);
+    this.props.eventManager.listen(document, 'click', this.handleClickOutside);
+
     if (!this.props.isMobile && !this.props.isSmallSize) {
       this.setState({position: this.getPosition()});
     }
   }
 
-  /**
-   * before component unmount, remove the event listener
-   *
-   * @returns {void}
-   * @memberof Menu
-   */
-  componentWillUnmount() {
-    document.removeEventListener('click', this.handleClickOutside);
-  }
-
   /**
    * get menu position based on document boundaries
    *
@@ -117,7 +108,6 @@ class Menu extends Component {
   handleClickOutside(e: any) {
     if (!this.props.isMobile && !this.props.isSmallSize && this._menuElement && !this._menuElement.contains(e.target)) {
       this.props.onClose();
-      e.stopPropagation();
     }
   }
 

src/components/settings/settings.js

@@ -166,9 +166,6 @@ class Settings extends Component {
       !this._controlSettingsElement.contains(e.target) &&
       this.state.smartContainerOpen
     ) {
-      if (e.target.classList.contains(style.overlayPlay)) {
-        e.stopPropagation();
-      }
       this.setState({smartContainerOpen: false});
     }
   }