Skip to content

Commit

Permalink
fix(FEC-12155): RTL languages translation are not supported correctly…
Browse files Browse the repository at this point in the history
… on the resolution labels (#691)

* fix(FEC-12155): RTL languages translation are not supported correctly on the resolution labels

* support more RTL languages

* define the array out of the render

* Update src/components/settings/settings.js

Co-authored-by: Sivan Agranov <88330203+SivanA-Kaltura@users.noreply.github.com>

Co-authored-by: Sivan Agranov <88330203+SivanA-Kaltura@users.noreply.github.com>
  • Loading branch information
Tzipi-kaltura and SivanA-Kaltura committed Sep 22, 2022
1 parent 1f5fdeb commit f6186f8
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion src/components/settings/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const HeightResolution = {
UHD_4K: 2160,
UHD_8K: 4320
};
const rtlLanguages = ['ae', 'ar', 'arc', 'bcc', 'bqi', 'ckb', 'dv', 'fa', 'glk', 'he', 'ku', 'mzn', 'nqo', 'pnb', 'ps', 'sd', 'ug', 'ur', 'yi'];

/**
* mapping state to props
Expand Down Expand Up @@ -319,10 +320,16 @@ class Settings extends Component {
// Progressive playback doesn't support auto
if (qualityOptions.length > 1 && player.streamType !== 'progressive') {
const activeTrack: Object = qualityOptions.find(track => track.value.active === true).value;
let qualityLabel;
if (rtlLanguages.includes(this.props.player._localPlayer._config.ui.locale)) {
qualityLabel = activeTrack.label + ' - ' + this.props.qualityAutoLabelText;
} else {
qualityLabel = this.props.qualityAutoLabelText + ' - ' + activeTrack.label;
}
qualityOptions.unshift({
label: this.props.qualityAutoLabelText,
dropdownOptions: {
label: this.props.qualityAutoLabelText + ' - ' + activeTrack.label,
label: qualityLabel,
badgeType: this.getLabelBadgeType(activeTrack.height)
},
active: player.isAdaptiveBitrateEnabled(),
Expand Down

0 comments on commit f6186f8

Please sign in to comment.