Skip to content

Commit

Permalink
fix(FEC-9006): invalid share CSS portal selector (#374)
Browse files Browse the repository at this point in the history
The CSS selector was too general, added the player instance selector prefix to it
  • Loading branch information
OrenMe committed Apr 2, 2019
1 parent 5dcb02c commit fa2c509
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/components/share/share.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,14 @@ class ShareControl extends BaseComponent {
return undefined;
}
const shareConfig = this._getMergedShareConfig();
const portalSelector = `#${this.player.config.targetId} .overlay-portal`;
return (
<div className={[style.controlButtonContainer, style.controlShare].join(' ')}>
<button className={style.controlButton} onClick={() => this.toggleOverlay()} aria-label="Share">
<Icon type={IconType.Share} />
</button>
{this.state.overlay ? (
<Portal into=".overlay-portal">
<Portal into={portalSelector}>
<ShareOverlay
shareUrl={shareUrl}
embedUrl={embedUrl}
Expand Down

0 comments on commit fa2c509

Please sign in to comment.