Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7196, FEC-7200): ios - live icon is not highlighted and scrubber at left #104

Merged
merged 1 commit into from
Oct 25, 2017
Merged

fix(FEC-7196, FEC-7200): ios - live icon is not highlighted and scrubber at left #104

merged 1 commit into from
Oct 25, 2017

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Oct 25, 2017 •
edited

Description of the Changes

'loadedmetadata' is too early to get duration on ios.
get it on loadeddata

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans self-assigned this Oct 25, 2017
@OrenMe OrenMe merged commit b21c603 into master Oct 25, 2017
@OrenMe OrenMe deleted the FEC-7196 branch October 25, 2017 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@dvh91 dvh91 Awaiting requested review from dvh91

@odedhutzler odedhutzler Awaiting requested review from odedhutzler

Assignees

@yairans yairans

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yairans @OrenMe