Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7321): position of fullscreen element in safari #108

Merged
merged 3 commits into from
Oct 26, 2017
Merged

fix(FEC-7321): position of fullscreen element in safari #108

merged 3 commits into from
Oct 26, 2017

Conversation

dvh91
Copy link

@dvh91 dvh91 commented Oct 26, 2017

Description of the Changes

kaltura-player-container is a non-ui css class and therefore should be with global in order to skip addition of css modules prefix.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

fix(FEC-7321): position of fullscreen element in safari bug fix. css
497b14f 
class wasn’t applied after the css modules change.
@dvh91 dvh91 self-assigned this Oct 26, 2017
@dvh91 dvh91 requested a review from dan-ziv October 26, 2017 04:26
@OrenMe OrenMe self-requested a review October 26, 2017 06:45
@OrenMe OrenMe merged commit ca60e82 into master Oct 26, 2017
@OrenMe OrenMe deleted the FEC-7321 branch October 26, 2017 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@dvh91 dvh91

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dvh91 @OrenMe