Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7275, FEC-7360): hide playkit ads ui on mobile #110

Merged
merged 1 commit into from
Oct 29, 2017
Merged

fix(FEC-7275, FEC-7360): hide playkit ads ui on mobile #110

merged 1 commit into from
Oct 29, 2017

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Oct 29, 2017 •
edited

Description of the Changes

The useDefaultAdsUimethod always returned false because we didn't sent it the props param.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Oct 29, 2017
@OrenMe OrenMe merged commit 81f8e2b into master Oct 29, 2017
@OrenMe OrenMe deleted the FEC-7360_FEC-7275 branch October 29, 2017 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@dvh91 dvh91 Awaiting requested review from dvh91

@yairans yairans Awaiting requested review from yairans

Assignees

@dan-ziv dan-ziv

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @OrenMe