Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unmute indication for autoplay with volume failed #117

Merged
merged 23 commits into from
Nov 6, 2017

Conversation

dvh91
Copy link

@dvh91 dvh91 commented Nov 1, 2017

Description of the Changes

Adding unmute indication in case player tried to autoplay with volume and failed.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dvh91 dvh91 self-assigned this Nov 1, 2017
@dvh91 dvh91 requested a review from dan-ziv November 1, 2017 13:35
@dan-ziv dan-ziv requested a review from OrenMe November 1, 2017 13:37
@OrenMe
Copy link
Contributor

OrenMe commented Nov 1, 2017

With ads the mute indication doesn't appear - need to handle and also make sure the new indication doesn't interfere with the top bar.
And also, seem like there's a regression as an exception is thrown when trying to use volume bar.

@dan-ziv dan-ziv changed the title feat: unmute indication for autoplay with volume failed. feat: unmute indication for autoplay with volume failed Nov 2, 2017
@OrenMe
Copy link
Contributor

OrenMe commented Nov 4, 2017

@dan-ziv @dvh91 please sync as this is causing the following behviour - when starting muted autoplay on Safari and clicking on the icon the ad pauses and the click handler goes crazy sometimes.

@dan-ziv dan-ziv merged commit 98a0c5d into master Nov 6, 2017
@dan-ziv dan-ziv deleted the mute-indication branch November 6, 2017 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants