Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-7157): dont show volume bar when smart container open #118

Merged
merged 1 commit into from
Nov 4, 2017
Merged

fix(FEC-7157): dont show volume bar when smart container open #118

merged 1 commit into from
Nov 4, 2017

Conversation

dvh91
Copy link

@dvh91 dvh91 commented Nov 2, 2017

Description of the Changes

adding player class when smart container menu open and using it as a dependency to show volume bar.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dvh91 dvh91 self-assigned this Nov 2, 2017
@dvh91 dvh91 requested a review from dan-ziv November 2, 2017 07:12
@OrenMe OrenMe merged commit 94c1066 into master Nov 4, 2017
@OrenMe OrenMe deleted the FEC-7157 branch November 4, 2017 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@dvh91 dvh91

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dvh91 @OrenMe