Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mute via iOS native player #121

Merged
merged 1 commit into from
Nov 6, 2017
Merged

fix: mute via iOS native player #121

merged 1 commit into from
Nov 6, 2017

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Nov 2, 2017 •
edited

Description of the Changes

If were muting/unmuting the player via the iOS native player, our UI was not updated.
The solution is to set the mute prop also in VOLUME_CHANGE event handler.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Nov 2, 2017
dvh91
dvh91 approved these changes Nov 6, 2017
View reviewed changes
Copy link

@dvh91 dvh91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dan-ziv dan-ziv merged commit bd06d12 into master Nov 6, 2017
@dan-ziv dan-ziv deleted the fix-ios-native-mute branch November 6, 2017 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvh91 dvh91 dvh91 approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

@yairans yairans Awaiting requested review from yairans

Assignees

@dan-ziv dan-ziv

Labels
Priority: High Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dan-ziv @dvh91