Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): hide quality selector in case of only 1 option #124

Merged
merged 2 commits into from
Nov 6, 2017
Merged

fix(settings): hide quality selector in case of only 1 option #124

merged 2 commits into from
Nov 6, 2017

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Nov 6, 2017 •
edited

Description of the Changes

If there's only one quality option then there's no reason to show quality menu for user selection

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe self-assigned this Nov 6, 2017
odedhutzler
odedhutzler approved these changes Nov 6, 2017
View reviewed changes
Copy link
Contributor

@odedhutzler odedhutzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OrenMe OrenMe merged commit f630c1f into master Nov 6, 2017
@OrenMe OrenMe deleted the FEC-7397 branch November 6, 2017 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvh91 dvh91 dvh91 approved these changes

@odedhutzler odedhutzler odedhutzler approved these changes

@yairans yairans Awaiting requested review from yairans

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@OrenMe OrenMe

Labels
Priority: Low Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OrenMe @dvh91 @odedhutzler